Skip to content

feat: DH-21757: Allow widget plugins to register types as dashboard types#2679

Merged
mofojed merged 4 commits into
deephaven:mainfrom
mofojed:DH-21757-widget-plugin-dashboard-types
May 14, 2026
Merged

feat: DH-21757: Allow widget plugins to register types as dashboard types#2679
mofojed merged 4 commits into
deephaven:mainfrom
mofojed:DH-21757-widget-plugin-dashboard-types

Conversation

@mofojed
Copy link
Copy Markdown
Member

@mofojed mofojed commented May 13, 2026

  • Allows widget plugins to register a type as a dashboard type, and create the dashboard payload
    • Avoids the current hack where the ui DashboardPlugin intercepts the panel open and then emits a dashboard creation, is more explicit about how it's handled
    • Also allows other plugins to potential register dashboard types
  • Used by feat: DH-21757: WidgetPlugin support in deephaven.ui deephaven-plugins#1341, Enterprise draft at https://github.com/deephaven-ent/iris/pull/4653
  • Leaves the door open for if we want to have an option for allowing dashboards to open as a panel by default (for now, you can just wrap a dashboard in a ui.panel)

@mofojed mofojed requested a review from dgodinez-dh May 13, 2026 21:11
@mofojed mofojed self-assigned this May 13, 2026
…ypes

- Allows widget plugins to register a type as a dashboard type, and create the dashboard payload
  - Avoids the current hack where the ui DashboardPlugin intercepts the panel open and then emits a dashboard creation, is more explicit about how it's handled
  - Also allows other plugins to potential register dashboard types
@mofojed mofojed force-pushed the DH-21757-widget-plugin-dashboard-types branch from fdfefce to eac1baa Compare May 13, 2026 21:22
@mofojed mofojed marked this pull request as ready for review May 13, 2026 21:22
@mofojed mofojed requested a review from vbabich May 13, 2026 21:22
Comment thread packages/dashboard-core-plugins/src/panels/ConsolePanel.tsx
Comment thread packages/plugin/src/PluginUtils.test.tsx Outdated
Comment thread packages/plugin/src/PluginUtils.tsx Outdated
@mofojed mofojed requested a review from dgodinez-dh May 14, 2026 18:51
Copy link
Copy Markdown
Contributor

@dgodinez-dh dgodinez-dh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. But looks like a few test failures.

@mofojed mofojed requested a review from dgodinez-dh May 14, 2026 20:48
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 59.18367% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.08%. Comparing base (0b5774e) to head (1e8a064).

Files with missing lines Patch % Lines
...dashboard-core-plugins/src/panels/ConsolePanel.tsx 39.39% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2679      +/-   ##
==========================================
- Coverage   50.28%   50.08%   -0.20%     
==========================================
  Files         774      774              
  Lines       44103    44148      +45     
  Branches    11372    11386      +14     
==========================================
- Hits        22178    22113      -65     
- Misses      21878    21989     +111     
+ Partials       47       46       -1     
Flag Coverage Δ
unit 50.08% <59.18%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mofojed mofojed merged commit 5028cf1 into deephaven:main May 14, 2026
10 of 11 checks passed
@mofojed mofojed deleted the DH-21757-widget-plugin-dashboard-types branch May 14, 2026 21:09
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants