feat: DH-21757: Allow widget plugins to register types as dashboard types#2679
Merged
mofojed merged 4 commits intoMay 14, 2026
Merged
Conversation
…ypes - Allows widget plugins to register a type as a dashboard type, and create the dashboard payload - Avoids the current hack where the ui DashboardPlugin intercepts the panel open and then emits a dashboard creation, is more explicit about how it's handled - Also allows other plugins to potential register dashboard types
fdfefce to
eac1baa
Compare
dgodinez-dh
requested changes
May 14, 2026
dgodinez-dh
reviewed
May 14, 2026
Contributor
dgodinez-dh
left a comment
There was a problem hiding this comment.
Changes look good. But looks like a few test failures.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2679 +/- ##
==========================================
- Coverage 50.28% 50.08% -0.20%
==========================================
Files 774 774
Lines 44103 44148 +45
Branches 11372 11386 +14
==========================================
- Hits 22178 22113 -65
- Misses 21878 21989 +111
+ Partials 47 46 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dgodinez-dh
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui.panel)