Skip to content

fix: DH-22318: incorrect typing in ConsoleContainer props and ConsolePanel handler signatures#2680

Open
ethanalvizo wants to merge 1 commit into
deephaven:mainfrom
ethanalvizo:22318_new_core_panel_typing
Open

fix: DH-22318: incorrect typing in ConsoleContainer props and ConsolePanel handler signatures#2680
ethanalvizo wants to merge 1 commit into
deephaven:mainfrom
ethanalvizo:22318_new_core_panel_typing

Conversation

@ethanalvizo
Copy link
Copy Markdown
Contributor

No description provided.

@ethanalvizo ethanalvizo self-assigned this May 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.29%. Comparing base (8c0cabb) to head (6580c8a).

Files with missing lines Patch % Lines
...es/dashboard-core-plugins/src/panels/CorePanel.tsx 66.66% 2 Missing ⚠️
...rd-core-plugins/src/panels/CommandHistoryPanel.tsx 0.00% 1 Missing ⚠️
...oard-core-plugins/src/panels/FileExplorerPanel.tsx 0.00% 1 Missing ⚠️
...ges/dashboard-core-plugins/src/panels/LogPanel.tsx 0.00% 1 Missing ⚠️
...ashboard-core-plugins/src/panels/NotebookPanel.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2680   +/-   ##
=======================================
  Coverage   50.28%   50.29%           
=======================================
  Files         774      775    +1     
  Lines       44103    44111    +8     
  Branches    11372    11372           
=======================================
+ Hits        22178    22186    +8     
  Misses      21878    21878           
  Partials       47       47           
Flag Coverage Δ
unit 50.29% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ethanalvizo ethanalvizo requested a review from mofojed May 14, 2026 14:32
Copy link
Copy Markdown
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but before we merge we should test this with a corresponding Enterprise change cleaning up the types. I've published an alpha package with your changes here: @deephaven/dashboard-core-plugins@1.19.1-console-types-fixes.0+6580c8a
Use that on the Enterprise side and get a PR ready that cleans up to use these new types and remove any workarounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants