Skip to content

mmc: phytium: Add driver version information for mmc#1556

Open
xx1263048898 wants to merge 1 commit intodeepin-community:linux-6.6.yfrom
xx1263048898:xx
Open

mmc: phytium: Add driver version information for mmc#1556
xx1263048898 wants to merge 1 commit intodeepin-community:linux-6.6.yfrom
xx1263048898:xx

Conversation

@xx1263048898
Copy link

@xx1263048898 xx1263048898 commented Mar 13, 2026

This patch add driver version information, which will be used to synchronize and manage driver patches in the future.

Summary by Sourcery

Add explicit version metadata to Phytium MMC/SDCI drivers for tracking and managing driver revisions.

New Features:

  • Expose version information for the Phytium SDCI MMC host driver via a defined driver version string and MODULE_VERSION.
  • Expose version information for the Phytium MMC host drivers (legacy and v2, PCI and platform variants) via dedicated driver version macros and MODULE_VERSION entries.

This patch add driver version information, which will be
used to synchronize and manage driver patches in the future.

Signed-off-by: Lai Xueyu <laixueyu1280@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Signed-off-by: Xu Xian <xuxian1552@phytium.com.cn>
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 13, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds explicit version metadata macros for Phytium MMC/SDCI drivers and wires them into the kernel module metadata via MODULE_VERSION, enabling driver version tracking and synchronization of future patches.

File-Level Changes

Change Details Files
Introduce driver version macros for each Phytium MMC/SDCI driver variant and use them in module metadata.
  • Define PHYTIUM_SDCI_DRIVER_VERSION, PHYTIUM_MMC_DRIVER_VERSION, and PHYTIUM_MMC_V2_DRIVER_VERSION string macros in the respective header or source files
  • Attach MODULE_VERSION() entries to all Phytium MMC/SDCI PCI, platform, and core driver modules using the new version macros
  • Keep existing MODULE_DESCRIPTION, MODULE_AUTHOR, and MODULE_LICENSE declarations unchanged while extending them with version information
drivers/mmc/host/phytium-sdci.c
drivers/mmc/host/phytium-mci.h
drivers/mmc/host/phytium-mci-v2.h
drivers/mmc/host/phytium-mci-pci.c
drivers/mmc/host/phytium-mci-plat.c
drivers/mmc/host/phytium-mci-plat-v2.c
drivers/mmc/host/phytium-mci-v2.c
drivers/mmc/host/phytium-mci.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

Hi @xx1263048898. Thanks for your PR. 😃

@deepin-ci-robot
Copy link

Hi @xx1263048898. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign avenger-285714 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider consolidating the various PHYTIUM_*_DRIVER_VERSION macros into a common header (or at least a shared location for MMC vs MMC v2) to avoid future divergence and make version bumps easier to manage.
  • If these version strings are intended for external tracking, it might be useful to clarify the relationship between the core driver versions (phytium-mci[-v2].c) and the bus-specific wrappers (PCI/platform) so it’s clear when multiple MODULE_VERSIONs should be updated together.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider consolidating the various PHYTIUM_*_DRIVER_VERSION macros into a common header (or at least a shared location for MMC vs MMC v2) to avoid future divergence and make version bumps easier to manage.
- If these version strings are intended for external tracking, it might be useful to clarify the relationship between the core driver versions (phytium-mci[-v2].c) and the bus-specific wrappers (PCI/platform) so it’s clear when multiple MODULE_VERSIONs should be updated together.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants