mmc: phytium: Add driver version information for mmc#1556
mmc: phytium: Add driver version information for mmc#1556xx1263048898 wants to merge 1 commit intodeepin-community:linux-6.6.yfrom
Conversation
This patch add driver version information, which will be used to synchronize and manage driver patches in the future. Signed-off-by: Lai Xueyu <laixueyu1280@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn> Signed-off-by: Xu Xian <xuxian1552@phytium.com.cn>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds explicit version metadata macros for Phytium MMC/SDCI drivers and wires them into the kernel module metadata via MODULE_VERSION, enabling driver version tracking and synchronization of future patches. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Hi @xx1263048898. Thanks for your PR. 😃 |
|
Hi @xx1263048898. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider consolidating the various PHYTIUM_*_DRIVER_VERSION macros into a common header (or at least a shared location for MMC vs MMC v2) to avoid future divergence and make version bumps easier to manage.
- If these version strings are intended for external tracking, it might be useful to clarify the relationship between the core driver versions (phytium-mci[-v2].c) and the bus-specific wrappers (PCI/platform) so it’s clear when multiple MODULE_VERSIONs should be updated together.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider consolidating the various PHYTIUM_*_DRIVER_VERSION macros into a common header (or at least a shared location for MMC vs MMC v2) to avoid future divergence and make version bumps easier to manage.
- If these version strings are intended for external tracking, it might be useful to clarify the relationship between the core driver versions (phytium-mci[-v2].c) and the bus-specific wrappers (PCI/platform) so it’s clear when multiple MODULE_VERSIONs should be updated together.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This patch add driver version information, which will be used to synchronize and manage driver patches in the future.
Summary by Sourcery
Add explicit version metadata to Phytium MMC/SDCI drivers for tracking and managing driver revisions.
New Features: