fix: accept logprobs as integer and warn on unsupported params#2
Open
fix: accept logprobs as integer and warn on unsupported params#2
Conversation
Change validate_no_unsupported_fields to log a warning instead of returning an error when unknown fields are present. This improves compatibility with clients that send extra parameters like add_special_tokens, prompt_cache_key, request_id, or chat_template. https://claude.ai/code/session_01EoHsvxn4B3WMuJkwP5f6od
c2bb87f to
e7e26cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logprobsfield to accept both boolean and integer values (0=false, non-zero=true). Some clients sendlogprobs: 1instead oflogprobs: true.validate_no_unsupported_fieldsto log a warning and continue instead of returning a 400 error. This improves compatibility with clients that send extra parameters likeadd_special_tokens,prompt_cache_key,request_id, andchat_template.Test plan
test_logprobs_accepts_integerverifies integer→bool coercion (0→false, 1→true) and that boolean values still worktest_unsupported_fields_warn_not_errorverifies that requests with unknown fields pass validationtest_chat_completions_unknown_fields_rejectedandtest_completions_unsupported_fields_rejectedto assertis_ok()instead ofis_err()https://claude.ai/code/session_01EoHsvxn4B3WMuJkwP5f6od