Skip to content

feat(skills): add deft-glossary skill#441

Open
visionik wants to merge 1 commit intomasterfrom
feat/skill-deft-glossary
Open

feat(skills): add deft-glossary skill#441
visionik wants to merge 1 commit intomasterfrom
feat/skill-deft-glossary

Conversation

@visionik
Copy link
Copy Markdown
Collaborator

Summary

Adds deft-glossary — a skill for extracting DDD-style ubiquitous language from conversations.

Scans conversation context for domain terms, flags ambiguities and synonyms, proposes a canonical glossary with opinionated term choices, and writes UBIQUITOUS_LANGUAGE.md. Integrates with core/glossary.md as a baseline when present (complementing the DDD framework work in #401).

Inspired by ubiquitous-language · mattpocock/skills


Warp conversation

…raction

Extracts domain terminology from conversation context into a canonical
UBIQUITOUS_LANGUAGE.md. Flags ambiguities, enforces canonical terms,
generates example dialogues demonstrating term composition.

Integrates with core/glossary.md as a baseline when present.
Inspired by ubiquitous-language (mattpocock/skills).
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 18, 2026

Greptile Summary

This PR adds deft-glossary, a new skill for extracting DDD-style ubiquitous language from conversations, writing results to UBIQUITOUS_LANGUAGE.md and optionally integrating with core/glossary.md. The skill itself is well-structured — clear process steps, opinionated term-picking rules, a template output format, and a solid anti-patterns section — but it is missing its registration in AGENTS.md's Skill Routing table, which is how all other skills in this repo are made discoverable to the agent.

  • Missing AGENTS.md routing entry: without an entry mapping "glossary" / "ubiquitous language" / "DDD" trigger keywords to skills/deft-glossary/SKILL.md, the skill is unreachable via the framework's primary routing mechanism.
  • CHANGELOG.md [Unreleased] section not updated, as required by AGENTS.md's pre-commit checklist.

Confidence Score: 4/5

Safe to merge once the AGENTS.md routing entry is added — the skill itself is correct but currently unreachable through the routing framework.

One P1 finding: the skill is not registered in AGENTS.md Skill Routing, meaning agents following the routing table won't be directed to it. All other findings are P2. The skill content itself is sound.

AGENTS.md (routing table needs a new entry for deft-glossary) and CHANGELOG.md (missing [Unreleased] entry)

Important Files Changed

Filename Overview
skills/deft-glossary/SKILL.md New skill file for DDD ubiquitous-language extraction. Well-structured with clear process steps, output format, and anti-patterns, but missing its AGENTS.md Skill Routing entry — the primary routing mechanism for the framework — and a CHANGELOG.md entry.
Prompt To Fix All With AI
This is a comment left during a code review.
Path: skills/deft-glossary/SKILL.md
Line: 1-14

Comment:
**AGENTS.md Skill Routing not updated**

`deft-glossary` is not registered in the `Skill Routing` table in `AGENTS.md`. Every other skill in the repo (deft-sync, deft-pre-pr, deft-interview, etc.) has a corresponding entry there that maps trigger keywords to its `SKILL.md` path. Without it, the routing framework in `AGENTS.md` won't direct the agent to this skill when users say "glossary", "DDD", or "domain model" — users and agents who follow AGENTS.md exclusively will never reach it.

Add an entry like:
```
- "glossary" / "ubiquitous language" / "domain model" / "DDD" / "define terms" → `skills/deft-glossary/SKILL.md`
```
to the Skill Routing section in `AGENTS.md`.

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: skills/deft-glossary/SKILL.md
Line: 1-14

Comment:
**CHANGELOG.md [Unreleased] entry missing**

AGENTS.md's development process requires "Add CHANGELOG.md entry under `[Unreleased]`" before committing. The `[Unreleased]` section is currently empty — this PR adds no entry for the new skill. A brief entry like `**deft-glossary skill** (#441): DDD ubiquitous-language extraction skill...` should appear there.

How can I resolve this? If you propose a fix, please make it concise.

Reviews (1): Last reviewed commit: "feat(skills): add deft-glossary skill fo..." | Re-trigger Greptile

Comment on lines +1 to +14
---
name: deft-glossary
description: >
Extract a DDD-style ubiquitous language glossary from the current
conversation, flagging ambiguities and proposing canonical terms. Saves
to UBIQUITOUS_LANGUAGE.md. Use when defining domain terms, building a
glossary, hardening terminology, or when "domain model" or "DDD" is mentioned.
triggers:
- domain model
- ubiquitous language
- glossary
- DDD
- define terms
---
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 AGENTS.md Skill Routing not updated

deft-glossary is not registered in the Skill Routing table in AGENTS.md. Every other skill in the repo (deft-sync, deft-pre-pr, deft-interview, etc.) has a corresponding entry there that maps trigger keywords to its SKILL.md path. Without it, the routing framework in AGENTS.md won't direct the agent to this skill when users say "glossary", "DDD", or "domain model" — users and agents who follow AGENTS.md exclusively will never reach it.

Add an entry like:

- "glossary" / "ubiquitous language" / "domain model" / "DDD" / "define terms" → `skills/deft-glossary/SKILL.md`

to the Skill Routing section in AGENTS.md.

Prompt To Fix With AI
This is a comment left during a code review.
Path: skills/deft-glossary/SKILL.md
Line: 1-14

Comment:
**AGENTS.md Skill Routing not updated**

`deft-glossary` is not registered in the `Skill Routing` table in `AGENTS.md`. Every other skill in the repo (deft-sync, deft-pre-pr, deft-interview, etc.) has a corresponding entry there that maps trigger keywords to its `SKILL.md` path. Without it, the routing framework in `AGENTS.md` won't direct the agent to this skill when users say "glossary", "DDD", or "domain model" — users and agents who follow AGENTS.md exclusively will never reach it.

Add an entry like:
```
- "glossary" / "ubiquitous language" / "domain model" / "DDD" / "define terms" → `skills/deft-glossary/SKILL.md`
```
to the Skill Routing section in `AGENTS.md`.

How can I resolve this? If you propose a fix, please make it concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant