Skip to content

Fix for "Properties ignored for select() without limit" bug #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chipple wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for "Properties ignored for select() without limit" bug #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/SQL/Abstract/Limit.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,8 @@ sub select {

$fields ||= '*'; # in case someone supplies '' or undef

# with no LIMIT parameters, defer to SQL::Abstract [ don't know why the first way fails ]
# return $self->SUPER::select( $table, $fields, $where, $order ) unless $rows;
return SQL::Abstract->new->select( $table, $fields, $where, $order ) unless $rows;
# with no LIMIT parameters, defer to SQL::Abstract
return $self->SUPER::select( $table, $fields, $where, $order ) unless $rows;

# with LIMIT parameters, get the basic SQL without the ORDER BY clause
my ( $sql, @bind ) = $self->SUPER::select( $table, $fields, $where );
Expand Down