feat(async/unstable): enhance CircuitBreaker with AbortSignal and onHalfOpen callback #6951
+339
−273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional AbortSignal to CircuitBreaker.execute() for pre-flight abort checking. This enables timeout and graceful shutdown scenarios when composing with other async primitives like retry(). - Add CircuitBreakerExecuteOptions interface with signal property - Check signal.throwIfAborted() before executing the function - Aborts do not count as circuit failures - Update JSDoc examples to show realistic usage patterns
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6951 +/- ##
==========================================
- Coverage 94.27% 94.07% -0.21%
==========================================
Files 584 600 +16
Lines 43169 43516 +347
Branches 6922 6984 +62
==========================================
+ Hits 40697 40936 +239
- Misses 2419 2526 +107
- Partials 53 54 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tomas-zijdemans
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isAvailable,failureCount,getStatsonHalfOpencallback for complete state observabilitysignaloption inexecute()for AbortSignal support