feat(http/unstable): add ServerSentEventParseStream for decoding SSE streams #6957
+549
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6957 +/- ##
==========================================
+ Coverage 94.08% 94.09% +0.01%
==========================================
Files 600 601 +1
Lines 43540 43640 +100
Branches 6991 7020 +29
==========================================
+ Hits 40965 41064 +99
- Misses 2520 2521 +1
Partials 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mfulton26
reviewed
Jan 16, 2026
| // Lines starting with colon are comments | ||
| if (line[0] === ":") { | ||
| const value = line.slice(1); | ||
| message.comment = message.comment !== undefined |
Contributor
There was a problem hiding this comment.
There could be large or many comments in the stream and in some use cases they may never be used by the consumer. What do you think of having an option to ignore comments to avoid unnecessary processing? (Maybe even having it enabled by default.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve: #6867