Skip to content

ci: add consolidated GitOps test workflow with validation#1287

Open
devantler wants to merge 10 commits intomainfrom
ci/test-ksail-cluster-action
Open

ci: add consolidated GitOps test workflow with validation#1287
devantler wants to merge 10 commits intomainfrom
ci/test-ksail-cluster-action

Conversation

@devantler
Copy link
Collaborator

@devantler devantler commented Mar 26, 2026

Purpose

Add a CI workflow that calls the consolidated ci-gitops-test reusable workflow, which now includes manifest validation as an early step (before cluster provisioning).

Changes

  • Added .github/workflows/ci-gitops-test.yaml calling the reusable workflow with VALIDATE: true
  • Validation runs before cluster creation, failing fast on invalid manifests

Related

What gets tested

  1. ksail workload validate — validates K8s manifests before any cluster provisioning
  2. Full cluster lifecycle — create → push → reconcile → delete (Talos + Docker)

Copilot AI review requested due to automatic review settings March 26, 2026 12:25
@botantler botantler bot enabled auto-merge March 26, 2026 12:25
@github-project-automation github-project-automation bot moved this from 🫴 Ready to 🚀 In Finalization in 🌊 Project Board Mar 26, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears intended to trigger/verify CI behavior related to a KSail validate fix and reusable workflow changes, but the only repository change included is a no-op formatting change to the README.

Changes:

  • Add a trailing blank line to README.md.

@devantler devantler changed the title ci: verify validate workflow with KSail sourceDirectory fix ci: add consolidated GitOps test workflow with validation Mar 26, 2026
Calls the ci-gitops-test reusable workflow which now includes
manifest validation as an early step before cluster provisioning.
Copilot AI review requested due to automatic review settings March 26, 2026 20:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings March 26, 2026 20:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Nikolai Emil Damm <ned@devantler.tech>
Copilot AI review requested due to automatic review settings March 26, 2026 20:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

- Pin devantler-tech/ksail/.github/actions/ksail-cluster from @main to
  @4cc958abae21913e32d6effbcc8c02bd1fe5a4f9
- Add environment: ci to the test job for secret protection
Signed-off-by: Nikolai Emil Damm <nikolaiemildamm@icloud.com>
Copilot AI review requested due to automatic review settings March 26, 2026 20:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

persist-credentials: false

- name: 🧪 System Test
uses: devantler-tech/ksail/.github/actions/ksail-cluster@4cc958abae21913e32d6effbcc8c02bd1fe5a4f9 # main
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uses: references in this repo appear to be pinned to a commit SHA with an inline comment indicating the released version (e.g., # v1.9.7, # v1.22.5). Here the action is pinned to a SHA but the comment says # main, which is misleading because it looks like a moving ref. Consider updating the comment to the actual release/tag for that SHA (or removing the comment) to keep dependency provenance clear and consistent.

Suggested change
uses: devantler-tech/ksail/.github/actions/ksail-cluster@4cc958abae21913e32d6effbcc8c02bd1fe5a4f9 # main
uses: devantler-tech/ksail/.github/actions/ksail-cluster@4cc958abae21913e32d6effbcc8c02bd1fe5a4f9

Copilot uses AI. Check for mistakes.
Comment on lines +12 to +28
environment: ci
steps:
- name: 📑 Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: 🧪 System Test
uses: devantler-tech/ksail/.github/actions/ksail-cluster@4cc958abae21913e32d6effbcc8c02bd1fe5a4f9 # main
with:
distribution: Talos
provider: Docker
init: "false"
validate: "true"
sops-age-key: ${{ secrets.SOPS_AGE_KEY }}
hosts-file: ${{ vars.HOSTS_FILE }}
root-ca-cert-file: ${{ vars.ROOT_CA_CERT_FILE }}
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow runs on pull_request but depends on secrets.SOPS_AGE_KEY and environment vars (HOSTS_FILE, ROOT_CA_CERT_FILE). For PRs from forks, GitHub does not provide repository secrets/variables, so this job will likely fail (or run with empty inputs). If forked PRs are expected, gate the job to non-fork PRs or split out a secretless validation job that still runs for forks.

Copilot uses AI. Check for mistakes.
Comment on lines +1 to +5
name: CI
on:
pull_request:
branches: [main]

Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says this adds a .github/workflows/ci-gitops-test.yaml workflow calling the consolidated ci-gitops-test reusable workflow, but the actual change adds .github/workflows/ci.yaml and runs the ksail-cluster composite action directly. Either update the PR description to match the implemented approach, or adjust the workflow to call the intended reusable workflow so the change is traceable and consistent with the stated design.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🚀 In Finalization

Development

Successfully merging this pull request may close these issues.

2 participants