refactor: consolidate dual ingress resources into unified configuration.#456
refactor: consolidate dual ingress resources into unified configuration.#456
Conversation
84cfa48 to
fde6717
Compare
66957cf to
f4d8779
Compare
|
This looks ideal 🙌 Thanks for addressing it so promptly! For context, I was looking into was to host pgstac-fastapi via k8s and had previous experience with eoAPI. I reached for this chart and it made the process super simple - seems like the best way to spin up a quick STAC to me 😁 The only thing I would comment is that the ingress definition in values.yaml seemed a bit fragmented between the global ingress and individual service ingress. It would be great to stick to one pattern or the other:
But its not a huge deal honestly, and changing this would of course introduce a breaking change, which is a bit of a pain |
91db042 to
ece3692
Compare
|
Thanks, @spwoodcock for having a look! Yes, you are right, it is worth to reflect on the global ingress configuration. It is definitively a tradeoff for operational simplicity, depending on the use case. For now I added a bit more pieces of documentation to make it clear. In the future we could consider rethinking this part, but i would prefer not to do this in this PR. |
6dbca7d to
87227ed
Compare
87227ed to
01274af
Compare
Closes #449 (fixes deployments with STAC only service).
This PR consolidates the ingress configuration by merging two ingress resources into a unified configuration. They have been there to address the problem that there are services that:
Previously, this was solved with two separate ingress resources (
ingress.yamlandingress-no-prefix.yaml), which was difficult to maintain and eventually caused issues such as #449.Therefore this PR proposes:
ingress-no-prefix.yamland refactoringress.yamlwith shared path templateeoapi.ingressPathshelper template$hasEnabledService) to prevent creating ingress resources with empty path arrays