Skip to content

Conversation

@JslYoon
Copy link
Contributor

@JslYoon JslYoon commented Jul 31, 2025

Description of Changes

Updated go version from 1.22 to 1.24

Related Issue(s)

#1701

Acceptance Criteria

Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.

@Jdubrick
Copy link
Contributor

Jdubrick commented Aug 1, 2025

@JslYoon are you able to sign your commits as well? I see one is but one wasn't so I believe that is why DCO is failing

… && updating gosec version

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
@JslYoon JslYoon force-pushed the feature/JslYoon/update-Go-modules branch from b96c7bd to 6589543 Compare August 1, 2025 20:25
@JslYoon
Copy link
Contributor Author

JslYoon commented Aug 1, 2025

@Jdubrick Should be all passing now except the snyk! Openshift-ci somehow removed my do-not-merge/work-in-progress tag for some reason :(

@JslYoon are you able to sign your commits as well? I see one is but one wasn't so I believe that is why DCO is failing

@JslYoon JslYoon requested a review from Jdubrick August 1, 2025 20:34
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jdubrick, JslYoon

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JslYoon JslYoon merged commit 2b3c776 into main Aug 5, 2025
8 of 9 checks passed
@JslYoon JslYoon deleted the feature/JslYoon/update-Go-modules branch August 5, 2025 18:05
@JslYoon JslYoon restored the feature/JslYoon/update-Go-modules branch August 5, 2025 19:19
@JslYoon JslYoon deleted the feature/JslYoon/update-Go-modules branch August 12, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants