Skip to content

feat: adding tmux to UDI 9 / 10 #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibuziuk merged 1 commit into from
May 4, 2026
Merged

feat: adding tmux to UDI 9 / 10 #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions universal/ubi10/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,40 @@ RUN dnf -y install bash-completion \
&& dnf clean all \
&& rm -rf /var/cache/yum

## tmux - using pre-built binaries (not available in UBI repos)
RUN <<'EOF'
set -euf -o pipefail

TEMP_DIR="$(mktemp -d)"
cd "${TEMP_DIR}"

TMUX_VERSION="3.6a"

case "$TARGETARCH" in
amd64)
TMUX_ARCH="x86_64"
;;
arm64)
TMUX_ARCH="arm64"
;;
*)
echo "Skipping tmux install for unsupported architecture: $TARGETARCH"
exit 0
;;
Comment on lines +561 to +576
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Avoid temp-dir leak on unsupported architectures.

Line 561 creates TEMP_DIR before the arch case; on unsupported arch (Line 575), script exits before cleanup (Line 588).

♻️ Proposed fix 
-TEMP_DIR="$(mktemp -d)"
-cd "${TEMP_DIR}"
-
 TMUX_VERSION="3.6a"
 
 case "$TARGETARCH" in
@@
     *)
         echo "Skipping tmux install for unsupported architecture: $TARGETARCH"
         exit 0
         ;;
 esac
 
+TEMP_DIR="$(mktemp -d)"
+cd "${TEMP_DIR}"
+
 TMUX_TGZ="tmux-${TMUX_VERSION}-linux-${TMUX_ARCH}.tar.gz"
 TMUX_TGZ_URL="https://github.com/tmux/tmux-builds/releases/download/v${TMUX_VERSION}/${TMUX_TGZ}"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
TEMP_DIR="$(mktemp -d)"
cd "${TEMP_DIR}"
TMUX_VERSION="3.6a"
case "$TARGETARCH" in
amd64)
TMUX_ARCH="x86_64"
;;
arm64)
TMUX_ARCH="arm64"
;;
*)
echo "Skipping tmux install for unsupported architecture: $TARGETARCH"
exit 0
;;
TMUX_VERSION="3.6a"
case "$TARGETARCH" in
amd64)
TMUX_ARCH="x86_64"
;;
arm64)
TMUX_ARCH="arm64"
;;
*)
echo "Skipping tmux install for unsupported architecture: $TARGETARCH"
exit 0
;;
esac
TEMP_DIR="$(mktemp -d)"
cd "${TEMP_DIR}"
TMUX_TGZ="tmux-${TMUX_VERSION}-linux-${TMUX_ARCH}.tar.gz"
TMUX_TGZ_URL="https://github.com/tmux/tmux-builds/releases/download/v${TMUX_VERSION}/${TMUX_TGZ}"
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@universal/ubi10/Dockerfile` around lines 561 - 576, The temp directory is
created unconditionally (TEMP_DIR="$(mktemp -d)") before the architecture check,
so the script can exit on unsupported architectures and leak TEMP_DIR; fix by
either moving the TEMP_DIR creation to after the case that sets TMUX_ARCH (so
mktemp only runs for supported arch), or add a cleanup trap immediately after
creating TEMP_DIR (e.g., trap 'rm -rf "$TEMP_DIR"' EXIT) and ensure any early
exits (the default case in the case statement that echoes and exits) will
trigger the trap; update the Dockerfile around the TEMP_DIR creation and the
architecture case to implement one of these two approaches and reference
TEMP_DIR, the case statement, and the default exit path.

Copy link
Copy Markdown
Collaborator

@dkwon17 dkwon17 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibuziuk could we move the:

TEMP_DIR="$(mktemp -d)"
cd "${TEMP_DIR}"

to after the case statement?

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

esac

TMUX_TGZ="tmux-${TMUX_VERSION}-linux-${TMUX_ARCH}.tar.gz"
TMUX_TGZ_URL="https://github.com/tmux/tmux-builds/releases/download/v${TMUX_VERSION}/${TMUX_TGZ}"

curl -sSLO "${TMUX_TGZ_URL}"
tar -xz --no-same-owner -f "${TMUX_TGZ}"
mv tmux /usr/local/bin/tmux
chmod +x /usr/local/bin/tmux
Comment on lines +582 to +585
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

TMUX_VERSION="3.6a"

echo "Release assets:"
curl -fsSL "https://api.github.com/repos/tmux/tmux-builds/releases/tags/v${TMUX_VERSION}" \
  | jq -r '.assets[].name' | sort

for arch in x86_64 arm64; do
  tgz="tmux-${TMUX_VERSION}-linux-${arch}.tar.gz"
  url="https://github.com/tmux/tmux-builds/releases/download/v${TMUX_VERSION}/${tgz}"
  echo "Inspecting ${tgz}"
  curl -fsSLO "${url}"
  tar -tzf "${tgz}" | head -n 20
  rm -f "${tgz}"
done

Repository: devfile/developer-images

Length of output: 309

🏁 Script executed:

# Read the Dockerfile to see the tmux installation block and surrounding context
cat -n universal/ubi10/Dockerfile | sed -n '570,595p'

Repository: devfile/developer-images

Length of output: 1019

🏁 Script executed:

# Search for other curl/tar installation patterns in the same Dockerfile to compare
rg -n "curl.*-O|tar.*-xz|checksum|sha256" universal/ubi10/Dockerfile | head -30

Repository: devfile/developer-images

Length of output: 1662

🏁 Script executed:

# Check if there's a .sha256 or checksum file available for tmux releases
curl -fsSL "https://api.github.com/repos/tmux/tmux-builds/releases/tags/v3.6a" | jq '.assets[] | {name, browser_download_url}'

Repository: devfile/developer-images

Length of output: 117

Verify tmux artifact integrity before installing binary.

Line 582 downloads and installs an executable without checksum validation. Multiple other tools in this Dockerfile (Krew, Helm, Kustomize, TKN, KN, Terraform, E2FSPROGS) verify checksums; tmux should follow the same pattern for supply-chain security. While tmux-builds does not publish checksums, consider alternative verification methods (e.g., GPG signatures if available, hash comparison with upstream documentation) or explicitly document the risk acceptance.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@universal/ubi10/Dockerfile` around lines 582 - 585, The Dockerfile currently
fetches and installs tmux using TMUX_TGZ_URL/ TMUX_TGZ without any integrity
checks; update the tmux install block to verify the artifact before moving it to
/usr/local/bin/tmux by either (1) adding a checksum verification step: obtain or
embed the expected SHA256 for TMUX_TGZ, download the checksum alongside the
tarball, run sha256sum (or openssl dgst -sha256) and abort the build on
mismatch, or (2) if an upstream GPG signature exists, fetch the signature and
upstream public key and verify the tarball before extraction, or (3) if neither
is available, add an explicit documented acceptance of risk and gate
installation with an opt-in build ARG (e.g., TMUX_INSECURE_ACCEPT) so the
default build fails; reference TMUX_TGZ_URL, TMUX_TGZ and the final install
steps (tar -xz ... mv tmux /usr/local/bin/tmux chmod +x) when implementing the
check and fail-fast behavior.

Copy link
Copy Markdown
Collaborator

@dkwon17 dkwon17 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibuziuk could we move the:

TEMP_DIR="$(mktemp -d)"
cd "${TEMP_DIR}"

to after the case statement?

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!


cd -
rm -rf "${TEMP_DIR}"
EOF

RUN <<EOF
oc completion bash > /usr/share/bash-completion/completions/oc
tkn completion bash > /usr/share/bash-completion/completions/tkn
Expand Down
34 changes: 34 additions & 0 deletions universal/ubi9/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,40 @@ RUN dnf -y install bash-completion \
&& dnf clean all \
&& rm -rf /var/cache/yum

## tmux - using pre-built binaries (not available in UBI repos)
RUN <<'EOF'
set -euf -o pipefail

TEMP_DIR="$(mktemp -d)"
cd "${TEMP_DIR}"

TMUX_VERSION="3.6a"

case "$TARGETARCH" in
amd64)
TMUX_ARCH="x86_64"
;;
arm64)
TMUX_ARCH="arm64"
;;
*)
echo "Skipping tmux install for unsupported architecture: $TARGETARCH"
exit 0
;;
esac

TMUX_TGZ="tmux-${TMUX_VERSION}-linux-${TMUX_ARCH}.tar.gz"
TMUX_TGZ_URL="https://github.com/tmux/tmux-builds/releases/download/v${TMUX_VERSION}/${TMUX_TGZ}"

curl -sSLO "${TMUX_TGZ_URL}"
tar -xz --no-same-owner -f "${TMUX_TGZ}"
mv tmux /usr/local/bin/tmux
chmod +x /usr/local/bin/tmux

cd -
rm -rf "${TEMP_DIR}"
EOF

RUN <<EOF
oc completion bash > /usr/share/bash-completion/completions/oc
tkn completion bash > /usr/share/bash-completion/completions/tkn
Expand Down
Loading