fix(codegen): disable datamodel-codegen timestamp header#18
Merged
Conversation
Without --disable-timestamp, every regen writes the current wall-clock time into the generated file's header, causing spec-check CI to open a PR on every run with a one-line timestamp-only diff. Also refreshes the regenerated file (one-line header removal) and picks up the already-published 0.5.0 version in uv.lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datamodel-codegenstamps a wall-clock timestamp into the generated file header. Every spec-check CI run regenerates the file with a fresh timestamp, producing a one-line diff and spamming PRs (see chore: update generated API types #17 — a pure-timestamp churn PR).Test plan
OPENAPI_TOOLS=node ../mini/packages/openapi-tools/dist/cli.js ./scripts/typegen.sh— produces no diff vs committed output after header removal.spec-propagateon mono; sdk-python Spec Check should go green with no open PR.Made with Cursor