fix(action): detect existing Node ≥18 before calling setup-node#2
Merged
Conversation
Previously the action's default node-version: '20' caused actions/setup-node@v4 to silently downgrade callers who had pinned Node 22+ via an earlier setup-node step. Add a Detect existing Node.js step that checks `node` on PATH and its major version. When Node ≥18 is already present we skip the inner setup-node entirely; otherwise we still install the configured node-version (default 20) as a fallback. Reword the input description and update the README to document the new behavior. Round-2 DevEx friction P1 — see /tmp/devex-r2-setup-devhelm/REPORT.md. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The action's default
node-version: '20'silently downgraded callers who already had Node 22+ set up by an earlieractions/setup-nodecall.Now: detect existing Node first; only install if missing or
<18. Thenode-versioninput is the version we install IF that fallback path runs.Round-2 DevEx friction P1 #5 (see /tmp/devex-r2-setup-devhelm/REPORT.md).
Test plan
yq eval . action.yml)Made with Cursor