Skip to content

fix: return 409 Conflict for duplicate resources and parse profile tags #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madhavilosetty-intel merged 1 commit into from
Mar 19, 2026
Merged

fix: return 409 Conflict for duplicate resources and parse profile tags #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/controller/httpapi/v1/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,5 +124,9 @@ func amtErrorHandle(c *gin.Context, err devices.AMTError) {

func notUniqueErrorHandle(c *gin.Context, err sqldb.NotUniqueError) {
msg := err.Console.FriendlyMessage()
c.AbortWithStatusJSON(http.StatusBadRequest, response{Error: msg, Message: msg})
if msg == "" {
msg = "resource already exists"
}

c.AbortWithStatusJSON(http.StatusConflict, response{Error: msg, Message: msg})
}
6 changes: 6 additions & 0 deletions internal/usecase/profiles/usecase.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,14 @@ func (uc *UseCase) BuildConfigurationObject(profileName string, data *entity.Pro
}
}

var tags []string
if data.Tags != "" {
tags = strings.Split(data.Tags, ",")
}

return config.Configuration{
Name: profileName,
Tags: tags,
Configuration: config.RemoteManagement{
GeneralSettings: config.GeneralSettings{
SharedFQDN: false,
Expand Down
2 changes: 2 additions & 0 deletions internal/usecase/profiles/usecase_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,6 +864,7 @@ func TestBuildConfigurationObject(t *testing.T) {
name: "successful configuration build",
profile: &entity.Profile{
ProfileName: "test-profile",
Tags: "tag1,tag2,tag3",
DHCPEnabled: true,
IPSyncEnabled: true,
Activation: "acmactivate",
Expand All @@ -887,6 +888,7 @@ func TestBuildConfigurationObject(t *testing.T) {
},
expected: config.Configuration{
Name: "test-profile",
Tags: []string{"tag1", "tag2", "tag3"},
Configuration: config.RemoteManagement{
GeneralSettings: config.GeneralSettings{
SharedFQDN: false,
Expand Down
Loading