Skip to content

Fix out-of-bounds array access in preposition vocabulary#22

Merged
Jan200101 merged 1 commit intodevshane:masterfrom
fuulish:fix_sigsegv
Feb 19, 2026
Merged

Fix out-of-bounds array access in preposition vocabulary#22
Jan200101 merged 1 commit intodevshane:masterfrom
fuulish:fix_sigsegv

Conversation

@fuulish
Copy link

@fuulish fuulish commented Jan 13, 2023

No description provided.

@fuulish
Copy link
Author

fuulish commented Feb 12, 2023

Hi, @devshane, I opened this pull request independently of PR #16, because I was transferring it from a separate, but similar implementation (richelbilderbeek/Zork#2). It'd be nice if either PR could be merged, because they fix the undefined behavior incurred by the array-out-of-bounds access (prplnt <-> pvoc).

@Jan200101
Copy link
Collaborator

merging this over #16

amended the commit to remove the volatile from the locals which was the previous workaround when I believed this to be caused by a compiler optimization error, this error originated from the original Fortran version and only became an issue when any agressive optimizations are used.

@Jan200101 Jan200101 merged commit cf4f69e into devshane:master Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants