Open
Conversation
Ultrix 4.2 contains a correct prototype for localtime so this should not be an issue anymore.
justwheel
approved these changes
Feb 21, 2026
Collaborator
justwheel
left a comment
justwheel
left a comment
There was a problem hiding this comment.
Not a C developer, but given the context from the removed-comment, this change seems sensible to me, given the newer context of Ultrix 4.2…
Collaborator
Author
|
An alternative solution would be removing the prototype at all, it should be pulled in by the header even on Ultrix and I am not aware why this used to be done. |
Collaborator
|
@jamesjer Would you be up for doing a peer review on this PR? |
This was referenced Feb 22, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ultrix 4.2 contains a correct prototype for localtime so this should not be an issue anymore.