chore(crypto): CRP-1799 Don't panic on invalid ZK proof instances in NIDKG#10015
Open
chore(crypto): CRP-1799 Don't panic on invalid ZK proof instances in NIDKG#10015
Conversation
…NIDKG Previously in NIDKG a proof instance type could be instantiated even if manifestly invalid; then check_instance would return an error. In some cases this error would propagate to the caller, but in others it would simply panic. Change this so that creating a ZK proof instance is falliable, and handle the error directly. This also eliminates any possibility of forgetting to call check_instance in the right spot.
Contributor
Author
|
Claude banged this out based on a 4 year old incomplete branch I had lying around, plus the ticket description. It looks good to me, and these panics were on the top of my list of remaining NIDKG nits. Merge or not as you please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in NIDKG a proof instance type could be instantiated even if manifestly invalid; then check_instance would return an error. In some cases this error would propagate to the caller, but in others it would simply panic.
Change this so that creating a ZK proof instance is falliable, and handle the error directly. This also eliminates any possibility of forgetting to call check_instance in the right spot.