Skip to content

Conversation

@daniel-wong-dfinity-org
Copy link
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org commented Dec 19, 2025

Only callable by Governance.

Part of NNS1-4295.

👈 Previous PR | Next PR 👉

github-actions[bot]

This comment was marked as resolved.

@daniel-wong-dfinity-org daniel-wong-dfinity-org dismissed github-actions[bot]’s stale review December 19, 2025 17:06
  1. Done.
  2. Existing APIs behave as before. Just added a new one.
  3. No existing data.
  4. Seems low risk, since this is only callable by Governance.
github-merge-queue bot pushed a commit that referenced this pull request Dec 19, 2025
…8158)

This functionality is not yet used by any canister, but the plan is for
Root to use this as part of the implementation of a new proposal type.

Part of [NNS1-4295].

[NNS1-4295]: https://dfinity.atlassian.net/browse/NNS1-4295

[Next PR 👉 ][next]

[next]: #8159
Base automatically changed from take-snapshot-management-client to master December 19, 2025 18:43
mraszyk pushed a commit that referenced this pull request Jan 5, 2026
…8158)

This functionality is not yet used by any canister, but the plan is for
Root to use this as part of the implementation of a new proposal type.

Part of [NNS1-4295].

[NNS1-4295]: https://dfinity.atlassian.net/browse/NNS1-4295

[Next PR 👉 ][next]

[next]: #8159
@daniel-wong-dfinity-org daniel-wong-dfinity-org force-pushed the take-snapshot-root-daniel-wong branch from 710aa82 to 55a4f98 Compare January 6, 2026 08:11
@daniel-wong-dfinity-org daniel-wong-dfinity-org force-pushed the take-snapshot-root-daniel-wong branch from 55a4f98 to 50ff466 Compare January 6, 2026 08:14
@daniel-wong-dfinity-org daniel-wong-dfinity-org added this pull request to the merge queue Jan 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2026
@daniel-wong-dfinity-org daniel-wong-dfinity-org added this pull request to the merge queue Jan 6, 2026
Merged via the queue into master with commit c525af4 Jan 6, 2026
38 checks passed
@daniel-wong-dfinity-org daniel-wong-dfinity-org deleted the take-snapshot-root-daniel-wong branch January 6, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants