added withUrlEncode function#27
Open
edwardteach42 wants to merge 1 commit intodflydev:mainfrom
edwardteach42:master
Open
added withUrlEncode function#27edwardteach42 wants to merge 1 commit intodflydev:mainfrom edwardteach42:master
edwardteach42 wants to merge 1 commit intodflydev:mainfrom
edwardteach42:master
Conversation
|
Your PR is a BC break and the tests are broken. To avoid it, the Anyway there are at least three points where you should skip the urlencode and urldecode calls: dflydev-fig-cookies/src/Dflydev/FigCookies/SetCookie.php Lines 159 to 161 in ecd9e50 dflydev-fig-cookies/src/Dflydev/FigCookies/Cookie.php Lines 61 to 64 in ecd9e50 dflydev-fig-cookies/src/Dflydev/FigCookies/StringUtil.php Lines 20 to 22 in fc5a026 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new option:
withUrlEncode(true);
This allows you to enable the php urlencod() on the cookie name and value if needed. This was necessary as most of my cookies are base64 encoded for AWS CloudFront and the equals symbol.