Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
get_table_dimensions()was underestimating the number of columns whenrowspanshifts cells into the next rows.This caused
handle_table()to access columns outside the grid, raising:Solution
Updated
get_table_dimensions()to simulate real table layout using aused_cellsgrid, accounting for bothrowspanandcolspan.Also added a small bounds check in
handle_table()for extra safety.Tests
Added a regression test for malformed tables where rowspan causes column overflow, ensuring:
Impact
Issue Reference
Fixes #70
Checklist Before Requesting a Review