Refactoring#3
Closed
dgenio wants to merge 12 commits intoempty_branchfrom
Closed
Conversation
New ci branch
Split clean data into 3 function ( plus an helper function) Add main function Change test to use main function
To give full code visibility to a new reviewer
rodrigo-veloso
approved these changes
Apr 18, 2023
| downcast="float", | ||
| errors="coerce" | ||
| ) | ||
| long_data = long_data.dropna(subset=["value"]) |
There was a problem hiding this comment.
I wouldn't use as many variable names for the different versions of the dataset.
Owner
Author
There was a problem hiding this comment.
I actually prefer it, to ensure I understand what's in the variable at each point.
|
|
||
| def test_clean_data(pt_life_expectancy_expected): | ||
| """Run the `main` function and compare the output to the expected output""" | ||
| main(country_code="PT") |
There was a problem hiding this comment.
i don't think you should change the argument of your test
Owner
Author
There was a problem hiding this comment.
Yeah, I clearly miss understood what I should do.
Remove argument on test as suggested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.