feat: [DHIS2-19940] Implement "No value" filtering for all filter types in working list#4468
Open
henrikmv wants to merge 248 commits intoDHIS2-21135from
Open
feat: [DHIS2-19940] Implement "No value" filtering for all filter types in working list#4468henrikmv wants to merge 248 commits intoDHIS2-21135from
henrikmv wants to merge 248 commits intoDHIS2-21135from
Conversation
…st filter Co-Authored-By: henrik.vadet@dhis2.org <henrik@devOtta.no>
Call getSearchOperator() in _setBaseProperties() so that program attributes used by working lists carry the correct searchOperator. This fixes both issues: - preferredSearchOperator was always undefined in working lists - unique TEAs were not using EQ operator (getSearchOperator handles this) Co-Authored-By: henrik.vadet@dhis2.org <henrik@devOtta.no>
Co-Authored-By: henrik.vadet@dhis2.org <henrik@devOtta.no>
…_EmptyValueFiltersForAllValueTypes
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DHIS2-19940
Pattern for Adding
isEmptyFiltering1. Types
EmptyValueFilterDatastringto theValuetype (used to carry the isEmpty value)2. Component
WithEmptyValueFilterundefinedto children whenisEmptyis active3. Data Getter
isEmptyValueFilter(value)before normal conversiongetEmptyValueFilterData(value)4. Manager
isEmptyFilterData(filter)getEmptyValueFilterValue(filter)5. Disable Flag
disableEmptyValueFiltertotruefor:transformRecordsFiltercolumns