Skip to content

feat(DHIS2-20879): support custom colors for header bar#63

Merged
kabaros merged 2 commits intomainfrom
DHIS2-20879/custom-colour
Mar 1, 2026
Merged

feat(DHIS2-20879): support custom colors for header bar#63
kabaros merged 2 commits intomainfrom
DHIS2-20879/custom-colour

Conversation

@kabaros
Copy link
Copy Markdown
Collaborator

@kabaros kabaros commented Feb 26, 2026

implement custom color for header bar

depends on depends on dhis2/dhis2-core#23061

custom-colour-behaviour.webm

@kabaros kabaros requested a review from KaiVandivier February 26, 2026 12:18
@kabaros kabaros marked this pull request as ready for review February 26, 2026 17:33
@kabaros kabaros force-pushed the DHIS2-20879/custom-colour branch from 9810d4c to 14885d0 Compare February 27, 2026 09:16
Copy link
Copy Markdown
Collaborator

@KaiVandivier KaiVandivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; good solution for the designs 🙌

-- We can figure out the status badge in a follow-up

(note the console log)

Comment thread src/components/get-contrasting-color.js Outdated
Comment on lines +10 to +13
console.log('apcaBlack', color, {
apcaWhite,
apcaBlack,
})
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging console log

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 1, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@kabaros kabaros merged commit d4dc338 into main Mar 1, 2026
4 of 5 checks passed
dhis2-bot added a commit that referenced this pull request Mar 1, 2026
# [1.10.0](v1.9.1...v1.10.0) (2026-03-01)

### Features

* **DHIS2-20879:** support custom colors for header bar ([#63](#63)) ([d4dc338](d4dc338))
@dhis2-bot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants