feat: support multiple split layers [DHIS2-19542]#3584
Open
BRaimbault wants to merge 71 commits intochore/DHIS2-18209-ThematicDialogfrom
Open
feat: support multiple split layers [DHIS2-19542]#3584BRaimbault wants to merge 71 commits intochore/DHIS2-18209-ThematicDialogfrom
BRaimbault wants to merge 71 commits intochore/DHIS2-18209-ThematicDialogfrom
Conversation
…ds to sort [DHIS2-6683] (#3541) Implements DHIS2-6683 Description * Disable text selection while dragging the layer cards * Disable map interactivity while dragging the layer cards The reason for the timeout in onSortEnd is because sometimes when releasing the drag (mouseUp), the css change happened so fast that some text got selected right at mouseUp. Delaying it 100ms seemed to fix that.
…[DHIS2-19716] (#3547) Support both ALL and F_EXTERNAL_MAP_LAYER_PUBLIC_ADD as maps-app admin authorities.
Update "Remove all existing layers to add a split map view." to "Remove all other layers to add a split map view."
5 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent PR: #3588 > chore: refactor ThematicDialog to functional component DHIS2-18209
Child PR: #3628 > feat: support multiple timeline layers DHIS2-19542
Implements DHIS2-19542
Description
This PR enables adding multiple split layers to a map.
Feats
src/components/map/SplitView.jsxsrc/components/map/MapView.jsxto pass layers as an array instead of single layersrc/util/helpers.jssrc/components/layers/overlays/LayerList.jsxsrc/components/layers/overlays/AddLayerPopover.jsxsrc/components/edit/thematic/ThematicDialog.jsxandsrc/components/edit/styles/LayerDialog.module.csssrc/components/edit/thematic/ThematicDialog.jsx#L268-L288src/components/periods/RenderingStrategy.jsxsrc/components/edit/thematic/ThematicDialog.jsx#L193-L204src/components/edit/thematic/ThematicDialog.jsx#L111-L117src/components/edit/thematic/ThematicDialog.jsx#L222-L224cypress/integration/layers/thematiclayer.cy.jssrc/components/periods/__tests__/RenderingStrategy.spec.jssrc/components/edit/thematic/validateThematicLayer.jssrc/components/edit/thematic/ThematicDialog.jsx#L308-L312src/actions/map.jssrc/constants/actionTypes.jssrc/reducers/map.jssrc/util/legend.jssrc/components/layers/LayerCard.jsxsrc/components/plugin/LegendLayer.jsxFixes
src/components/map/MapItem.jsxto properly handle 2 map items (DHIS2-19808).Chores
src/components/edit/thematic/validateThematicLayer.js.src/components/periods/CalendarInput.jsxsrc/hooks/useLayersLoader.jsandsrc/components/app/App.jsxQuality checklist
Add N/A to items that are not applicable.
Testing