refactor(pdfkit): align reference.js with upstream and switch Buffer polyfill to node-stdlib-browser#3409
Open
exoego wants to merge 1 commit intodiegomura:masterfrom
Open
Conversation
The previous rollup-plugin-polyfill-node (unmaintained for ~2.5 years) bundled an outdated inline Buffer impl whose Buffer.concat rejected bare Uint8Array. Fontkit v2.x's subset.encode() returns a Uint8Array, since they are migrating codebase to Uint8Array, so generating a PDF with embedded fonts in the browser threw "argument must be an Array of Buffers" So, switched to node-stdlib-browser + @rollup/plugin-inject The bundled buffer@5.7+ accepts Uint8Array per current spec Plus, keeps src/reference.js byte-identical with upstream foliojs/pdfkit (no source patches, no shim)
🦋 Changeset detectedLatest commit: 671a238 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
exoego
changed the title
exoego
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR keeps
src/reference.jsbyte-identical with upstream foliojs/pdfkit (no source patches, no shim) as part of #2613The previous rollup-plugin-polyfill-node (unmaintained for ~2.5 years) bundled an outdated inline Buffer impl whose
Buffer.concatrejected bareUint8Array.Fontkit v2.x's
subset.encode()returns a Uint8Array, since they are migrating codebase to Uint8Array, so generating a PDF with embedded fonts in the browser threw "argument must be an Array of Buffers".So, switched to node-stdlib-browser + @rollup/plugin-inject .
The newly bundled
buffer@5.7+acceptsUint8Arrayper current Buffer spec.