fix(types): inline Primitive enum values for isolatedModules compatibility + sync enums#3411
Open
benasher44 wants to merge 2 commits intodiegomura:masterfrom
Open
fix(types): inline Primitive enum values for isolatedModules compatibility + sync enums#3411benasher44 wants to merge 2 commits intodiegomura:masterfrom
benasher44 wants to merge 2 commits intodiegomura:masterfrom
Conversation
The Primitive enum in primitive.d.ts initializes values from @react-pdf/primitives runtime imports, which breaks under TypeScript's isolatedModules mode. Inline the string literal values directly since they are stable constants.
|
Add missing enum members (FieldSet, TextInput, Select, Checkbox, List, ImageBackground, Marker) and a bidirectional test that checks every enum value matches @react-pdf/primitives and vice versa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Primitiveenum inpackages/types/primitive.d.tsinitializes its values from@react-pdf/primitivesruntime imports:This breaks under TypeScript's
isolatedModulesmode (andverbatimModuleSyntax), because enum members cannot be initialized from imported values when each file must be independently transpilable.Fixed by inlining the string literal values directly + added a test to ensure these stay in sync