fix(Card): don't require class="ds-link" on links, since that wasn't recommended until recently#4896
fix(Card): don't require class="ds-link" on links, since that wasn't recommended until recently#4896unekinn wants to merge 1 commit into
class="ds-link" on links, since that wasn't recommended until recently#4896Conversation
🦋 Changeset detectedLatest commit: 62664ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
unekinn
force-pushed
the
fix/card-link-without-ds-link
branch
from
5bd0b58 to
3d97e7d
Compare
|
Preview deployments for this pull request: storybook - |
…t recommended until recently We [used to recommend](https://github.com/digdir/designsystemet/blob/48e991ddae92e30cc3a07dba95cecb46f5aec50b/packages/react/src/components/card/card.stories.tsx#L141-L147) using plain `<a>` elements without `class="ds-link"`, so there will be plenty of usages like that in the wild.
unekinn
changed the title
.ds-link class on links in Card, since that wasn't recommended until recentlyclass="ds-link" on links, since that wasn't recommended until recently
unekinn
force-pushed
the
fix/card-link-without-ds-link
branch
from
3d97e7d to
62664ba
Compare
| "@digdir/designsystemet-css": patch | ||
| --- | ||
|
|
||
| **Card**: when using a link in a Card, ensure plain `<a>` tags without `class="ds-link"` also get the correct focus styling. |
There was a problem hiding this comment.
| **Card**: when using a link in a Card, ensure plain `<a>` tags without `class="ds-link"` also get the correct focus styling. | |
| **Card**: fix when using a link in a Card, ensure plain `<a>` tags without `class="ds-link"` also get the correct focus styling. |
There was a problem hiding this comment.
Why? 🤔 It will be grouped under Patch changes in the changelog already, and your suggested sentence makes less sense to me.
2 participants
Summary
Ensures Cards with
<a>in a heading element get the correct focus styling, even whenclass="ds-link"is omitted.We used to recommend using plain
<a>elements withoutclass="ds-link", so there will be plenty of usages like that in the wild.Before - tab through the links and see that the first link has wrong focus style
After - the focus styles are now the same
Checks
pnpm changesetif relevant)