Feat: rework sidebar toggle to work with hasSidebar property and adde…#46
Open
GlennDigipolis wants to merge 1 commit intodigipolisantwerp:master-v1from
Open
Feat: rework sidebar toggle to work with hasSidebar property and adde…#46GlennDigipolis wants to merge 1 commit intodigipolisantwerp:master-v1from
GlennDigipolis wants to merge 1 commit intodigipolisantwerp:master-v1from
Conversation
…d new showSidebar prop
| <span class="fa fa-close" aria-hidden="true"></span> | ||
| </button> | ||
| <h1 class="has-base-font u-text-bold h5">Lagen</h1> | ||
| <div class="u-margin-left-xs"> |
Contributor
There was a problem hiding this comment.
Is er een reden waarom je niet gewoon u-margin gebruikt op de container? Nu is de padding waarschijnlijk wat onregelmatig, plus verschillende paddings op verschillende plaatsen lokken nogal snel layout issues uit.
| selector: 'aui-layer-management', | ||
| templateUrl: './layer-management.component.html', | ||
| styleUrls: ['./layer-management.component.scss'], | ||
| templateUrl: './layer-management.component.html' |
Contributor
There was a problem hiding this comment.
Tip, de komma laten wij altijd staan (ook op de laatste regel), zodat dat gemakkelijker leest in reviews).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d new showSidebar prop