Conversation
davidlehn
left a comment
There was a problem hiding this comment.
- Should add a github action to run these.
- Is "fixture" term use ok? I thought that was more the broader testing setup vs only the test data here. Can be changed later if needed.
- Should perhaps target a different branch. It's overlapping with other PRs.
Ah. I see. I had the branches stacked locally, but GitHub ignores that when you make a PR... It's possible to later edit that (or maybe set it via the CLI), but I forgot to do that. Sorry for the confusion. |
|
@davidlehn GitHub Action added. Obligatory |
I've changed the base to |
Hit the title edit button and you can change the target branch. |
davidlehn
left a comment
There was a problem hiding this comment.
Getting a bit confused with the multiple prs and what was changed where. Like the node_modules ignore is here too.
| run: npm run lint | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 360 |
There was a problem hiding this comment.
360 is the default. I'd hope tests don't take that long! Maybe this should be lower or removed if default is fine.
| @@ -10,12 +12,34 @@ jobs: | |||
| matrix: | |||
| node-version: [20.x] | |||
There was a problem hiding this comment.
| node-version: [20.x] | |
| node-version: [24.x] |
| timeout-minutes: 360 | ||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] |
There was a problem hiding this comment.
| node-version: [20.x] | |
| node-version: [20.x, 22.x, 24.x] |
| data.should.be.an('object'); | ||
| data.should.have.property('@context'); |
There was a problem hiding this comment.
This can be a full check too right?
| data.should.be.an('object'); | |
| data.should.have.property('@context'); | |
| data.should.deep.equal(JSON.parse(fixtureData)); |
| parsed.should.be.an('object'); | ||
| parsed.should.have.property('@context'); |
There was a problem hiding this comment.
This can be a full check too, right?
| parsed.should.be.an('object'); | |
| parsed.should.have.property('@context'); | |
| parsed.should.deep.equal(JSON.parse(fixtureData)); |
fixturestodata.