Fix conflict with simplito/bigint-wrapper-php#3
Open
brianrlewis wants to merge 1 commit intodigitaldonkey:masterfrom
Open
Fix conflict with simplito/bigint-wrapper-php#3brianrlewis wants to merge 1 commit intodigitaldonkey:masterfrom
brianrlewis wants to merge 1 commit intodigitaldonkey:masterfrom
Conversation
This fix prevents an 'Exception: Invalid characters' error in vendor/simplito/bigint-wrapper-php/lib/BigInteger.php:328 that occurs when php-gmp is not installed which causes BigInteger.php to use php-bcmath as a fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fix for the problem described in issue #2.
All unit tests continue to pass with this fix in place, both on platforms using gmp and on those using bcmath instead.