Skip to content

Comments

fix(metric3d): remove metric3d to fix tests#1341

Merged
paul-nechifor merged 1 commit intodevfrom
paul/fix/remove-metric3d
Feb 22, 2026
Merged

fix(metric3d): remove metric3d to fix tests#1341
paul-nechifor merged 1 commit intodevfrom
paul/fix/remove-metric3d

Conversation

@paul-nechifor
Copy link
Contributor

Problem

Tests were broken.

Closes DIM-568

https://linear.app/dimensional/issue/DIM-568/remove-metric3d

Solution

Remove Metric3D. It was only used by the drone and not used for anything useful.

Breaking Changes

None.

How to Test

Run all the tests.

Note: I can't check with the physical drone.

Contributor License Agreement

  • I have read and approved the CLA.

@paul-nechifor paul-nechifor changed the base branch from main to dev February 21, 2026 22:26
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 21, 2026

Greptile Summary

Removes Metric3D depth estimation model and all associated code to fix broken tests. This PR deletes the entire dimos.environment and dimos.models.depth modules, removes depth processing from drone and Unitree camera modules, and cleans up all references from module registries. The removal is comprehensive and affects 13 files with approximately 700 lines of code deleted.

  • Deleted dimos/environment/ module (178 lines) - abstract Environment class
  • Deleted dimos/models/depth/metric3d.py (187 lines) and its tests (102 lines)
  • Deleted dimos/robot/unitree/depth_module.py (243 lines)
  • Updated dimos/robot/drone/camera_module.py to remove depth processing, eliminating depth_image and depth_colorized output channels
  • Removed depth-related LCM transports from dimos/robot/drone/drone.py
  • Cleaned up module registries in all_blueprints.py and unitree_webrtc/__init__.py
  • Deleted binary ONNX model file metric3d_vit_small.onnx
  • Updated documentation to reflect removal of depth estimation features

All references to Metric3D, the environment module, and depth_module have been successfully removed with no remaining imports found in the codebase.

Confidence Score: 5/5

  • This PR is safe to merge - it's a clean removal with no broken references
  • The removal is complete and thorough with no remaining imports or references to the deleted code. All module registries have been updated, documentation reflects the changes, and the scope is well-defined (fixing broken tests by removing unused Metric3D functionality).
  • No files require special attention

Important Files Changed

Filename Overview
dimos/models/depth/metric3d.py Deleted Metric3D depth estimation model implementation (187 lines)
dimos/robot/all_blueprints.py Removed depth_module from all_modules registry
dimos/robot/drone/camera_module.py Removed Metric3D depth processing logic and depth output channels
dimos/robot/unitree/depth_module.py Deleted Unitree depth module that used Metric3D (243 lines)
dimos/robot/unitree_webrtc/init.py Removed depth_module from module alias registry

Last reviewed commit: 7e0610e

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@paul-nechifor paul-nechifor merged commit a9b6c56 into dev Feb 22, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants