Skip to content

Comments

fix(tests): fix#1343

Draft
paul-nechifor wants to merge 6 commits intodevfrom
paul/fix/testing-docs-2
Draft

fix(tests): fix#1343
paul-nechifor wants to merge 6 commits intodevfrom
paul/fix/testing-docs-2

Conversation

@paul-nechifor
Copy link
Contributor

@paul-nechifor paul-nechifor commented Feb 22, 2026

Problem

Closes DIM-XXX

Solution

Breaking Changes

How to Test

Contributor License Agreement

  • I have read and approved the CLA.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 22, 2026

Greptile Summary

Consolidated test infrastructure by standardizing on slow marker and custom skipif_* markers to simplify test categorization and CI workflow.

Key changes:

  • Replaced fragmented markers (integration, heavy, module, e2e, neverending) with unified slow marker across all test files
  • Merged 4 separate CI test jobs into single run-slow-tests job running pytest -m 'slow or lcm'
  • Introduced custom conditional markers (skipif_in_ci, skipif_no_openai, skipif_no_alibaba) in conftest.py for cleaner test declarations
  • Improved test cleanup by adding proper stop_rpc_client() and close_all() calls to prevent resource leaks
  • Fixed test_spatial_memory_module.py to use tf system correctly for odometry
  • Removed unused test file test_moduleDB.py
  • Updated documentation to reflect new marker system and testing philosophy

Confidence Score: 5/5

  • Safe to merge - test infrastructure refactoring with no production code changes
  • This PR only touches test files, CI configuration, and documentation. All changes are mechanical marker replacements and cleanup improvements. No functional/production code is modified.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/docker.yml Consolidated 4 test jobs (run-heavy-tests, run-lcm-tests, run-integration-tests) into single run-slow-tests job; removed commented code
dimos/conftest.py Added custom skipif_* markers for conditional test skipping; updated _skip_for list from heavy to slow
pyproject.toml Removed obsolete markers (heavy, module, e2e, integration, neverending); added slow marker; simplified addopts filter
docs/development/testing.md Updated documentation to reflect new marker system and custom skipif_* markers; clarified fast vs slow test strategy
dimos/core/test_stream.py Changed @pytest.mark.module to @pytest.mark.slow; renamed stop() to unsub_all(); added proper cleanup with stop_rpc_client() and close_all()
dimos/core/test_core.py Changed @pytest.mark.module to @pytest.mark.slow; replaced dimos.shutdown() with proper cleanup sequence
dimos/perception/test_spatial_memory_module.py Changed @pytest.mark.neverending to @pytest.mark.slow; refactored odometry to use tf system; renamed streams; improved cleanup
dimos/perception/detection/test_moduleDB.py Deleted unused/incomplete test file (59 lines removed)

Last reviewed commit: 2090f1e

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

33 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@paul-nechifor paul-nechifor marked this pull request as draft February 22, 2026 06:40
@paul-nechifor paul-nechifor force-pushed the paul/fix/testing-docs-2 branch from 7a25393 to 9ba633d Compare February 22, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant