fix(tests): replace sleep() with threading.Event in pubsub tests

[leshy]

Problem

Pubsub test_spec.py was flakey (https://github.com/dimensionalOS/dimos/actions/runs/22268096362/job/64417900362)

No matching Linear issue

Solution

Replaced time.sleep() waits with threading.Event in three tests:

• test_store: single event, set on callback
• test_multiple_subscribers: one event per subscriber
• test_multiple_messages: event set when expected count reached

Each uses event.wait(timeout=1.0) so tests fail clearly on timeout instead of hanging

Breaking Changes

None

How to Test

pytest dimos/protocol/pubsub/test_spec.py -v

Contributor License Agreement

• I have read and approved the CLA.

[greptile-apps]

Greptile Summary

Replaces inefficient busy-wait loops with threading.Event for message synchronization in three pubsub tests (test_store, test_multiple_subscribers, test_multiple_messages), adding proper 1-second timeouts to prevent indefinite hangs.

• Removed time.sleep() polling in favor of event.wait(timeout=1.0)
• Each test now has clear timeout behavior with descriptive error messages
• Removed debug print statement from test_store

Confidence Score: 4/5

• Safe to merge with minimal risk - improves test reliability
• Clean refactoring of test synchronization primitives with proper timeout handling, though one edge case around concurrent callback execution could theoretically occur
• No files require special attention

Important Files Changed

Filename	Overview
dimos/protocol/pubsub/test_spec.py	Replaced busy-wait loops with threading.Event for cleaner timeout handling in pubsub tests

_{Last reviewed commit: 522b50d}

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}