Skip to content

[fix][libexpr] Fix issue about string to decimal. #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
githubgxll merged 1 commit into from
Dec 16, 2025
Merged

[fix][libexpr] Fix issue about string to decimal. #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/types/decimal/decimal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,20 @@ namespace types {
Decimal::Decimal(const std::string & var) {
try {
int i = 0;
bool followingE = false;

for (; i < var.length(); i++) {
if (var[i] != '.' && var[i] != 'e' && var[i] != 'E'
if (var[i] == 'e' || var[i] == 'E') {
followingE = true;
}
if ((var[i] == '-' || var[i] == '+') && i != 0 && !followingE) {
followingE = false;
break;
} else if (var[i] != '.' && var[i] != 'e' && var[i] != 'E'
&& var[i] != '-' && var[i] != '+'
&& (var[i] < 0x30 || var[i] > 0x39)) {
break;
}
}
}

if (i == 0) {
Expand Down
2 changes: 1 addition & 1 deletion src/types/decimal/decimal_p.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class DecimalP {
}

DecimalP operator-() const {
return -(*m_ptr);
return Decimal("0") - (*m_ptr);
}

bool operator==(const DecimalP &v) const {
Expand Down