Skip to content

[fix][libexpr] Fix issue about decimal eq and ne. #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
githubgxll merged 1 commit into from
Dec 19, 2025
Merged

[fix][libexpr] Fix issue about decimal eq and ne. #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 41 additions & 6 deletions src/types/decimal/decimal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,14 @@ class Decimal {
* @return
*/
bool operator==(const Decimal &dec) const {
return v == dec.getMpf();
const mpf_class& mpf1 = mpf_class(toString());
const mpf_class& mpf2 = mpf_class(dec.toString());

int ret = cmp(mpf1, mpf2);
if(ret == 0) {
return true;
}
return false;
}

/**
Expand All @@ -228,7 +235,7 @@ class Decimal {
* @return
*/
bool operator!=(const Decimal &dec) const {
return v != dec.getMpf();
return !(*this == dec);
}

/**
Expand All @@ -237,7 +244,14 @@ class Decimal {
* @return
*/
bool operator<(const Decimal &dec) const {
return v < dec.getMpf();
const mpf_class& mpf1 = mpf_class(toString());
const mpf_class& mpf2 = mpf_class(dec.toString());

int ret = cmp(mpf1, mpf2);
if(ret < 0) {
return true;
}
return false;
}

/**
Expand All @@ -246,7 +260,14 @@ class Decimal {
* @return
*/
bool operator<=(const Decimal &dec) const {
return v <= dec.getMpf();
const mpf_class& mpf1 = mpf_class(toString());
const mpf_class& mpf2 = mpf_class(dec.toString());

int ret = cmp(mpf1, mpf2);
if(ret <= 0) {
return true;
}
return false;
}

/**
Expand All @@ -255,7 +276,14 @@ class Decimal {
* @return
*/
bool operator>(const Decimal &dec) const {
return v > dec.getMpf();;
const mpf_class& mpf1 = mpf_class(toString());
const mpf_class& mpf2 = mpf_class(dec.toString());

int ret = cmp(mpf1, mpf2);
if(ret > 0) {
return true;
}
return false;
}

/**
Expand All @@ -264,7 +292,14 @@ class Decimal {
* @return
*/
bool operator>=(const Decimal &dec) const {
return v >= dec.getMpf();
const mpf_class& mpf1 = mpf_class(toString());
const mpf_class& mpf2 = mpf_class(dec.toString());

int ret = cmp(mpf1, mpf2);
if(ret >= 0) {
return true;
}
return false;
}

/**
Expand Down