Fix: return prop compatibility for previous and current doc versions#149
Open
brynpttrsn wants to merge 7 commits intodiscordjs:mainfrom
Open
Fix: return prop compatibility for previous and current doc versions#149brynpttrsn wants to merge 7 commits intodiscordjs:mainfrom
brynpttrsn wants to merge 7 commits intodiscordjs:mainfrom
Conversation
iCrawl
reviewed
May 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes missing " or " between return types.
Fixes missing return descriptions on older generated docs.
Fixes nullable return types on older generated docs
Resolves #146
Current Docs:
CommandInteractionOptionResolver#getMentionable
-no "or" between return types
v13 CommandInteractionOptionResolver#get
-nothing nullable and no descriptions for returns
Deploy Preview:
CommandInteractionOptionResolver#getMentionable
v13 CommandInteractionOptionResolver#get