feat: EPSR Node#2414
Draft
RobBuchananCompPhys wants to merge 5 commits intodevelop2from
Draft
Conversation
RobBuchananCompPhys
force-pushed
the
dissolve2/epsr-node-part-1
branch
2 times, most recently
from
2e8f12c to
163d92f
Compare
trisyoungs
reviewed
Apr 24, 2026
Member
trisyoungs
left a comment
trisyoungs
left a comment
There was a problem hiding this comment.
Have had a cursory look through this. Some of the necessary changes feel a bit clunky - absolutely not your fault, just what you've had to engineer to get it working in its new context. Hopefully we can do some refactoring once the basic integration is successful.
Spotted a probable bug (noted in a comment).
RobBuchananCompPhys
force-pushed
the
dissolve2/epsr-node-part-1
branch
from
c26c22c to
d0a1c00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.