Conversation
rprospero
requested review from
RobBuchananCompPhys and
trisyoungs
and removed request for
trisyoungs
trisyoungs
left a comment
trisyoungs
left a comment
There was a problem hiding this comment.
Well, std::format_to is a nice thing! This all looks fine, but I think we should go a step further and have two nodes, each focussing on a specific format (I also think we should refer to "Configurations" rather than "Coordinates" as we have historically done) - ExportXYZConfiguration and ExportDLPolyConfiguration. This means we separate out options for specific file formats (not that we have any here, but the future is looming....) and remove the CoordinateExportFormat completely.
rprospero
force-pushed
the
export_coordinates_node
branch
from
2af87c9 to
56e99cc
Compare
rprospero
force-pushed
the
export_coordinates_node
branch
from
56e99cc to
4dfc439
Compare
trisyoungs
left a comment
trisyoungs
left a comment
There was a problem hiding this comment.
Bunch of nitpicky suggestions, but all in good spirit! 😃
| addOption<bool>("TagWithIteration", "Whether to tag (suffix) the filename with the current iteration index", | ||
| tagWithIteration_); |
There was a problem hiding this comment.
I wonder if we shouldn't mention, or use, "iteration" at all in future? This is not something for consideration in this PR, but this option could morph into something like an "Overwrite" option, which if true just keeps writing to the same (non-suffixed) file, but if false seeks out the next suffix number to use based on the pre-existing files.
|
@rprospero Just noticed that the source files also need renaming ("Coordinates" -> "Configuration") too. |
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
2 participants
This adds an ExportCoordinatesNode to go along side the ExportTrajectoryNode.