Skip to content

[DIT-12414] Support filtering by integrated flag#135

Merged
marla-hoggard merged 1 commit intomasterfrom
marla/dit-12414-integrated-flag
Mar 24, 2026
Merged

[DIT-12414] Support filtering by integrated flag#135
marla-hoggard merged 1 commit intomasterfrom
marla/dit-12414-integrated-flag

Conversation

@marla-hoggard
Copy link
Copy Markdown
Contributor

@marla-hoggard marla-hoggard commented Mar 23, 2026

Overview

Adds the ability to filter the pull command response by integrated - whether or not the items have been marked as integrated into development.

Supports top-level and output-specific integrated: boolean flags.

Does not include support for applying the integrated filter to the individual project or component folder filters; those still only support id and no additional filters.

@bparrish17 I notice that getSwiftDriverFile.ts includes project and folder filters but nothing else. Is that correct? Should it be updated to include statuses and integrated filters as well?

Context

https://linear.app/dittowords/issue/DIT-12414/update-cli-config-to-support-isdevintegrated-filter

Test Plan

  • Visit Ditto and mark some text items and components as integrated
  • Clear out any test data you may already have in the CLI
  • Point your local CLI to local ditto via .env vars + make sure to start the api via yarn start:api in ditto-app
  • Run yarn start pull - you should receive the exact same data as in master
  • Update your config.yml file to add integrated: true at the top level
  • Confirm that for each project/component folder you're pulling from, only items marked isDevIntegrated: true show up in the results
  • For the json formatters, only projects that return data should be generated, empty projects don't make empty files
  • For the mobile formatters, all projects are generated, even if empty
  • Add a few different outputs to your config file with different formats and outDir paths
  • Add integrated: false to some of those outputs
  • If an output has the integrated flag, that output should use that flag's value
  • If an output doesn't have the integrated flag, the top-level integrated filter should be used
  • If there is no integrated flag in an output or top level, no integrated filter should be applied, items with both true and false values should be returned

Copy link
Copy Markdown
Contributor

@bparrish17 bparrish17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

@marla-hoggard marla-hoggard merged commit 6aadc3a into master Mar 24, 2026
1 check passed
@jholiga jholiga mentioned this pull request Mar 27, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants