Add expected-value uncertainty modeling#30
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
div0rce
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3af694777
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ('label' in current) { | ||
| throw new Error(`Invalid uncertain number at ${pathString(segments)}`); |
There was a problem hiding this comment.
label fields in uncertainty traversal
collectUncertaintyAssumptions throws whenever it sees any object with a label key unless the object is an UncertainNumber, which makes expected-value rollout fail on normal engine state shapes that legitimately contain labels (for example NormalizedCard.label and EngineObjectiveProfile.label in lib/engine/types.ts). In practice, calling runExpectedValueHorizonRollout with a realistic EngineState will error with Invalid uncertain number ... before any sampling, so EV rollout is unusable for the primary state model.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
this is why you're the goat 😭
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Testing
PATH=/Users/nasr/.nvm/versions/node/v24.15.0/bin:$PATH CHERRY_TMP_ROOT=/Users/nasr/.cherry-tmp/codex-pr12 npm run check-> passedPATH=/Users/nasr/.nvm/versions/node/v24.15.0/bin:$PATH CHERRY_TMP_ROOT=/Users/nasr/.cherry-tmp/codex-pr12 npm test-> passedPATH=/Users/nasr/.nvm/versions/node/v24.15.0/bin:$PATH CHERRY_TMP_ROOT=/Users/nasr/.cherry-tmp/codex-pr12 CHERRY_VINE_SIGNATURE_MODE=enforce npm run build-> passedRisk