Skip to content

Conversation

@HamidH97
Copy link

@HamidH97 HamidH97 commented Dec 16, 2025

Fixes #

Description of the Change

This PR improves lookup performance in OAuth2Validator._get_token_from_authentication_server by using the indexed token_checksum field instead of the unindexed token field.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS
  • tests/app/idp updated to demonstrate new features
  • tests/app/rp updated to demonstrate new features

@HamidH97 HamidH97 changed the title fix: use token_checksum for lookup in _get_token_from_authentication_… fix: use token_checksum for lookup in _get_token_from_authentication_server Dec 16, 2025
@HamidH97 HamidH97 force-pushed the fix/access-token-update-or-create-lookup branch from fcf87b7 to 1238fcd Compare December 16, 2025 17:06
@HamidH97 HamidH97 force-pushed the fix/access-token-update-or-create-lookup branch from 1238fcd to 95c8912 Compare December 16, 2025 17:06
@n2ygk n2ygk self-requested a review December 16, 2025 17:49
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for this.

Please wait on #1631 to get merged by @dopry and then rebase this PR to resolve the broken check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants