Skip to content

Bug with singleton, support for dashes in file name #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SaintRyoh wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bug with singleton, support for dashes in file name #6

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c62a2b4
provider instance not being returned unless it's a singleton
SaintRyoh Apr 4, 2023
a63d9ec
Merge pull request #1 from SaintRyoh/provider-instance
SaintRyoh Apr 6, 2023
d2e05fd
support for dashes in directory names
SaintRyoh Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lua-di/DependencyInjectionModule.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ local DependencyInjectionModule = function(configure)
end

if autoInjectEnabled then
local moduleName = argumentName:gsub("__", ".")
local moduleName = argumentName:gsub("___", "-"):gsub("__", ".")

return self.getInstance(moduleName)
end
Expand Down Expand Up @@ -170,6 +170,11 @@ local DependencyInjectionModule = function(configure)
return singletons[moduleName].instance
end

if instance then
-- provider instance
return instance
end

local moduleHandle = dynamicRequire(moduleName)
local moduleConstructor = getConstructor(moduleName, moduleHandle)

Expand Down