Add AArch64 to src/core/thread/types.d#22722
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#22722" |
|
@kinke another one that mysteriously doesn't have support for AArch64? |
|
LDC has a |
|
@kinke : druntime/src/core/thread/types.d is in druntime/mak/SRCS. How does it not get compiled by ldc and not trigger the assert? |
|
Well, LDC doesn't use the Makefiles, but uses CMake. And compiles the file obviously. With the mentioned LDC-specific |
|
Oddly, that LDC section does not exist in master. |
cd91855 to
17954e8
Compare
|
I fixed it for DigitalMars and added the missing LDC section in. |
|
(Quite a few mods/hacks in LDC's druntime and Phobos haven't been upstreamed.) |
|
Wouldn't that make life difficult for you as then you have to constantly check for changes in master and fold them into the LDC versions? |
|
Oh, merge conflicts in druntime/Phobos occur very seldomly, and are usually extremely trivial to resolve. The absolute least of my worries whenever syncing LDC with latest DMD/Phobos |
No description provided.