Skip to content

Add AArch64 to src/core/thread/types.d#22722

Merged
WalterBright merged 1 commit intodlang:masterfrom
WalterBright:stackgrows
Mar 12, 2026
Merged

Add AArch64 to src/core/thread/types.d#22722
WalterBright merged 1 commit intodlang:masterfrom
WalterBright:stackgrows

Conversation

@WalterBright
Copy link
Member

No description provided.

@WalterBright WalterBright added Review:Easy Review Arch:Aarch64 Issues specific to Arm 64 Druntime Specific to druntime labels Mar 12, 2026
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22722"

@WalterBright
Copy link
Member Author

@kinke another one that mysteriously doesn't have support for AArch64?

@kinke
Copy link
Contributor

kinke commented Mar 12, 2026

LDC has a version (LDC) branch for this, similar to the GCC one here.

@WalterBright
Copy link
Member Author

@kinke : druntime/src/core/thread/types.d is in druntime/mak/SRCS. How does it not get compiled by ldc and not trigger the assert?

@kinke
Copy link
Contributor

kinke commented Mar 12, 2026

Well, LDC doesn't use the Makefiles, but uses CMake. And compiles the file obviously. With the mentioned LDC-specific version(LDC)-branch: https://github.com/ldc-developers/ldc/blob/57996fb5b7afbf2cb3d25fe2470b26caf86769fc/runtime/druntime/src/core/thread/types.d#L42-L49

@WalterBright
Copy link
Member Author

Oddly, that LDC section does not exist in master.

@WalterBright
Copy link
Member Author

I fixed it for DigitalMars and added the missing LDC section in.

@kinke
Copy link
Contributor

kinke commented Mar 12, 2026

(Quite a few mods/hacks in LDC's druntime and Phobos haven't been upstreamed.)

@WalterBright
Copy link
Member Author

Wouldn't that make life difficult for you as then you have to constantly check for changes in master and fold them into the LDC versions?

@kinke
Copy link
Contributor

kinke commented Mar 12, 2026

Oh, merge conflicts in druntime/Phobos occur very seldomly, and are usually extremely trivial to resolve. The absolute least of my worries whenever syncing LDC with latest DMD/Phobos stable. - Some mods should be upstreamed, others I'm not so sure about (as it affects readability of upstream druntime).

@WalterBright WalterBright merged commit 82a68e2 into dlang:master Mar 12, 2026
41 of 42 checks passed
@WalterBright WalterBright deleted the stackgrows branch March 13, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch:Aarch64 Issues specific to Arm 64 Druntime Specific to druntime Review:Easy Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants