Skip to content

Add TODO AArch64 to find places that need work in druntime #22730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewilsonator merged 1 commit into from
Mar 14, 2026
Merged

Add TODO AArch64 to find places that need work in druntime #22730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions druntime/src/core/internal/atomic.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ version (AArch64)
{
/* These functions are all stubbed out. They await someone who knows what
they are doing with AArch64 atomics.
TODO AArch64
*/
enum IsAtomicLockFree(T) = T.sizeof <= size_t.sizeof * 2;

Expand Down
4 changes: 2 additions & 2 deletions druntime/src/core/thread/osthread.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,7 +1548,7 @@ in (fn)
mov [sp], sp;
*/
}
assert(0, "implement AArch64 inline assembler for callWithStackShell()");
assert(0, "implement AArch64 inline assembler for callWithStackShell()"); // TODO AArch64
}
else
{
Expand Down Expand Up @@ -1600,7 +1600,7 @@ private extern(D) void* getStackTop() nothrow @nogc
else version (D_InlineAsm_X86_64)
asm pure nothrow @nogc { naked; mov RAX, RSP; ret; }
else version (AArch64)
asm pure nothrow @nogc { naked; mov x0, SP; ret; }
asm pure nothrow @nogc { naked; mov x0, SP; ret; } // TODO AArch64
else version (GNU)
return __builtin_frame_address(0);
else
Expand Down
Loading