chore: [main-review] minor improvements and review updates, mainly in…#2
Merged
chore: [main-review] minor improvements and review updates, mainly in…#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… test/main.ts
Added additional tests for LoggerImpl for getLevel/ActionLabel and toShortString and additional scenarios for toString for LoggerImpl. Additional tests to basic classes such as LogEvent, Layout and ConsoleAppender.
Added: git-basics.md
Fixed the issues found testing the framework under Office Script. Now the framework works in both environments node.js/typescript and Office Script and all tests passed in both environments.