Make it possible to exclude certain fields via translateWithDeepl#23
Open
Teddytrombone wants to merge 1 commit intodmitryd:masterfrom
Open
Make it possible to exclude certain fields via translateWithDeepl#23Teddytrombone wants to merge 1 commit intodmitryd:masterfrom
Teddytrombone wants to merge 1 commit intodmitryd:masterfrom
Conversation
…t only include them
Owner
|
This would not work in all cases because it would skip all other checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment it's only possible to force inclusion to translatable fields but it's not possible to force exclusion. This change checks, if translateWithDeepl is set in the configuration. If not, everything works like before. If sit is set, the result is the bool casted value of translateWithDeepl, so it can be true or false.