Skip to content

Enable 0-3 video modes#126

Closed
donno2048 wants to merge 1 commit intodmsc:masterfrom
donno2048:patch-2
Closed

Enable 0-3 video modes#126
donno2048 wants to merge 1 commit intodmsc:masterfrom
donno2048:patch-2

Conversation

@donno2048
Copy link
Copy Markdown
Contributor

the check is anyways if((ax & 0x7F) > 3) for not entering the video setting function, so why not?

@donno2048 donno2048 mentioned this pull request Feb 25, 2026
@dmsc
Copy link
Copy Markdown
Owner

dmsc commented Mar 16, 2026

Hi!

Thank you for your contributions.

This is OK, but IMHO, it should set 40x25 for modes 0 and 1 to support programs that use that modes.

Have Fun!

@donno2048
Copy link
Copy Markdown
Contributor Author

Hi!

Thank you for your contributions.

This is OK, but IMHO, it should set 40x25 for modes 0 and 1 to support programs that use that modes.

Have Fun!

It does...

@dmsc
Copy link
Copy Markdown
Owner

dmsc commented Mar 16, 2026

Sorry, I misread that part.

Ok, will merge!

@donno2048
Copy link
Copy Markdown
Contributor Author

I think you forgot to hit merge... 😅

@dmsc
Copy link
Copy Markdown
Owner

dmsc commented Mar 20, 2026

Sorry, merged now!

@dmsc dmsc closed this Mar 20, 2026
@donno2048
Copy link
Copy Markdown
Contributor Author

@dmsc I think you accidentally closed instead of merged

@donno2048
Copy link
Copy Markdown
Contributor Author

Oh,
350467f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants