Closed
Conversation
This was referenced Mar 16, 2026
Closed
Contributor
Author
|
As mentioned in #129 this also has the side effect of allowing a key combination to perform special operations to the emulator (like exiting) except in very rare edge cases |
Owner
|
This has a few problems:
I will revamp keyboard handling by introducing a proper keyboard buffer, instead of "queued_key", the emulator should maintain a buffer of 16 entries in 40h:01Eh, this is what a real PC BIOS does and some programs depend on that. At emulator_update, the keyboard should be read, keys added to the buffer and the pointer updated. Currently, emu2 only updates the buffer pointer at 40h:01Ah. Have Fun! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes both #130 and #132 irrelevant while still solving the issue