Do not let the vendored md-ts-mode claim Markdown files globally#157
Merged
Do not let the vendored md-ts-mode claim Markdown files globally#157
Conversation
pi-coding-agent uses the vendored md-ts-mode as an internal rendering engine for chat buffers. When that file registers itself in auto-mode-alist and treesit-major-mode-remap-alist, merely loading pi-coding-agent changes how unrelated Markdown files open throughout Emacs. That breaks user expectations and interferes with configurations that rely on markdown-mode hooks and keymaps. Remove those global registrations from the vendored copy, clarify that md-ts-mode opt-in remains explicit, and strengthen regression coverage. The tests now verify both loading the vendored mode itself and loading pi-coding-agent leave Markdown file associations untouched. A shared batch-Emacs test helper initializes packages before evaluation so the package-load regression test exercises the real loading path. See: #155
dnouri
force-pushed
the
fix-155-no-global-md-registration
branch
from
7945dad to
741fe78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pi-coding-agent uses the vendored md-ts-mode as an internal rendering engine for chat buffers. When that file registers itself in auto-mode-alist and treesit-major-mode-remap-alist, merely loading pi-coding-agent changes how unrelated Markdown files open throughout Emacs. That breaks user expectations and interferes with configurations that rely on markdown-mode hooks and keymaps.
Remove those global registrations from the vendored copy, clarify that md-ts-mode opt-in remains explicit, and strengthen regression coverage. The tests now verify both loading the vendored mode itself and loading pi-coding-agent leave Markdown file associations untouched. A shared batch-Emacs test helper initializes packages before evaluation so the package-load regression test exercises the real loading path.
See: #155